Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release 1.30] Add guardrail for etcd-snapshot #11394

Open
wants to merge 1 commit into
base: release-1.30
Choose a base branch
from
Open

[Release 1.30] Add guardrail for etcd-snapshot #11394

wants to merge 1 commit into from

Conversation

manuelbuil
Copy link
Contributor

Backport: #11314
Issue: #11390

FOR JANUARY RELEASE

@manuelbuil manuelbuil requested a review from a team as a code owner November 28, 2024 09:09
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 42.23%. Comparing base (c79db1b) to head (4dd0f5f).

Files with missing lines Patch % Lines
pkg/cluster/managed.go 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.30   #11394      +/-   ##
================================================
- Coverage         46.75%   42.23%   -4.52%     
================================================
  Files               179      179              
  Lines             18729    18739      +10     
================================================
- Hits               8757     7915     -842     
- Misses             8625     9625    +1000     
+ Partials           1347     1199     -148
Flag Coverage Δ
e2etests 34.27% <72.72%> (-7.91%) ⬇️
inttests 34.67% <72.72%> (-0.07%) ⬇️
unittests 13.72% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasferrandiz thomasferrandiz thomasferrandiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manuelbuil @thomasferrandiz